Regression in jsr223, roadmap?

Ruby JRuby
1

Dear Devs,

I ran into a regression when upgrading from 1.2.0 to 1.5.2; so I am
wondering about the roadmap and whether a fix is coming.
It’s a simple one related to the JSR223 interface:
this used to work with 1.2.0 (actually the corresponding extra jsr233
engine jar)
jrubyContext.setAttribute(ScriptEngine.FILENAME, fileName,
ScriptContext.ENGINE_SCOPE);
but not on the 1.5.x , where the ScriptEngine was rewritten (RedBridge I
think).

Now, this apparently got a fix on master, months ago
(Add ScriptEngine.FILENAME handling to three eval methods. Also, fix l… · jruby/jruby@7bda00f · GitHub),
however, it never made it to jruby-1_5 branch.
I now cherry picked that commit and it seems to do the trick.

So… just a few questions:

  1. do you think for me it’s OK to just cherry pick that, then ‘ant
    clean jar-complete’ (I only need the jar).

  2. The tag ‘1.5.2’ corresponds exactly to the contents of the 1.5.2
    release, right?
    To build the patched jar, I brought this fix onto the jruby-1_5
    latest…
    which is a few commits further down to that tag (selector pool, etc…).
    Do you think this is safe enough, or should I branch off the release
    tag and only patch that?

  3. Is a 1.5.3 planned for soon? If so, can we include the above fix?

  4. is 1.6 coming soon? Will that be released from master?

  5. Do you think the current master is stable enough?

  6. Is there a better place to look for this info? e.g roadmap, what’s
    coming, status of branches (not just build status), what decides when
    to release, etc…

  7. should I report that bug? (note: it’s fixed on master).

  8. Should I publish that -trivial- fix on a github fork?

Sorry if this was overwhelming, but could see another obvious way to
figure this out.

Thanks in advance,

Gergo

To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
2

Hi,

On Thu, Sep 16, 2010 at 7:07 AM, Gergely N. [email protected] wrote:

(http://github.com/jruby/jruby/commit/7bda00f315d70c3e68359ca549f970f79137c7f9),
however, it never made it to jruby-1_5 branch.
I now cherry picked that commit and it seems to do the trick.

I haven’t recognized this for a long time since nobody reported the
problem. Sorry.
I cherry-picked the fix to jruby-1_5 branch today. So, the next 1.5
release will have this fix.

So… just a few questions:

  1. do you think for me it’s OK to just cherry pick that, then ‘ant
    clean jar-complete’ (I only need the jar).

Yes. The fix is small and affects only under org.jruby.embed packages.
There’s no bad effect on other parts of JRuby.

  1. The tag ‘1.5.2’ corresponds exactly to the contents of the 1.5.2
    release, right?
    To build the patched jar, I brought this fix onto the jruby-1_5 latest…
    which is a few commits further down to that tag (selector pool, etc…).
    Do you think this is safe enough, or should I branch off the release
    tag and only patch that?

I think it is safe but not sure about tag. Maybe Tom will change the
tag when the next 1.5 will be released.

  1. Is a 1.5.3 planned for soon? If so, can we include the above fix?

  2. is 1.6 coming soon? Will that be released from master?

  3. Do you think the current master is stable enough?

As for embedding API including JSR223, master might behave a bit
different. I changed internal API a lot these days. All tests have
passed so far, but more tests are needed to make it completely
consistent.

-Yoko

To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
3

On Thu, Sep 16, 2010 at 11:56 AM, Yoko H. [email protected] wrote:

but not on the 1.5.x , where the ScriptEngine was rewritten (RedBridge I think).

which is a few commits further down to that tag (selector pool, etc…).
Do you think this is safe enough, or should I branch off the release
tag and only patch that?

I think it is safe but not sure about tag. Maybe Tom will change the
tag when the next 1.5 will be released.

The head of jruby-1_5 is what will be in 1.5.3. We put very few fixes
into 1.5 branch and those fixes should be very safe so there should be
no danger. We will be putting out 1.5.3 in the next week to so you
can wait for the new release too if you like.

-Tom

  1. Is a 1.5.3 planned for soon? If so, can we include the above fix?

whoops answered above.

  1. is 1.6 coming soon? Will that be released from master?

1.6 is from master and will probably be early Novemberish, but we
still have not set a particular date.

  1. Do you think the current master is stable enough?

We largely all work off of master and run a lot of tests and real life
code against it. The general confidence level is good for running off
of master.

to release, etc…
Gergo
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

–
blog: http://blog.enebo.com twitter: tom_enebo
mail: [email protected]

To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email