Code Review: RandomRubyFixes01

Ruby IronRuby
1

tfpt review “/shelveset:RandomRubyFixes01;REDMOND\curth”

Comment :
Fix many bugs in Marshal; now passes all but 5 tests
Implement Time._load and Time._dump to support marshaling of Time
objects
Implement “arity” function for method groups
Correctly scope the constant when looking for the YAML module in
yaml_as

2

I wonder why you removed spec comments from TimeOps? Not that I object
that, just curious if our convention is not to include such things into
the code.
Also you marked some methods in Marshal as private, while a bunch of
them still left with no access modifier, I think we should be more
consistent here and mark everything with explicit access modifiers.

Otherwise looks great.

Oleg

3

Right, our convention is not to copy documentation from ri.
I agree on access modifiers.

Tomas

4

I thought I had gotten all the access modifiers but I think I got bored
with adding them and lost focus. :wink: I’ll fix that.

5

Does that mean I should remove the documentation from the Numeric
classes,
too? In that code I had put them in as C# xml documentation i.e.
///

… kind of stuff. Is this not wanted any more?
Pete