Gr_modtool generating incorrect code?

rowland · January 26, 2013, 11:13pm

I’m using gr_modtool as described in the OutOfTree Modules
http://gnuradio.org/redmine/projects/gnuradio/wiki/OutOfTreeModules#The-C-code-part-1
to generate the square_ff block. However, the code generated produces an
error when compiled and is different from the code in the
/howto-write-a-block directory. E.g., in the generated
…/gr-howto/lib/howto_square_ff.cc file there is the line
gr_make_io_signature (<+MIN_IN+>, <+MAX_IN+>, sizeof (<+float+>))
which needs to be

.
.
static const int MIN_IN = 1; // mininum number of input streams
static const int MAX_IN = 1; // maximum number of input streams
.
.
gr_make_io_signature (MIN_IN, MAX_IN, sizeof (float)),

Do the values for <+MIN_IN+> and <+MAX_IN+> need to be set somewhere so
that the proper code gets generated?

rowland · January 29, 2013, 4:45pm

I just now downloaded and installed gr_modtool from

github.com

mbr0wn/gr-modtool/blob/master/gr_modtool.py

#!/usr/bin/env python
""" A tool for editing GNU Radio modules. """
# Copyright 2010 Communications Engineering Lab, KIT, Germany
#
# This is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3, or (at your option)
# any later version.
#
# This software is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with GNU Radio; see the file COPYING.  If not, write to
# the Free Software Foundation, Inc., 51 Franklin Street,
# Boston, MA 02110-1301, USA.
#

This file has been truncated. show original

which is 2 hours old. When a new module is being added an error occurs
because it attempts to get the skeleton from

/home/braun/.usrlocal/share/gnuradio/modtool/gr-newmod

Using the code from a previous version of gr_modtool I fixed the code
so that the skeleton comes from the NEWMOD_TARFILE.

Although this change allows gr_modtool to correctly generate the module
I STILL have the problem described in my original post. I.e. in the
block added by gr_modtool there is the file
…/gr-howto/lib/square_ff_impl.cc file which has the line
gr_make_io_signature (<+MIN_IN+>, <+MAX_IN+>, sizeof (<+float+>))
I have to manually fix this by lifting the code out the
gnuradio/gr-howto-write-a-block and changing
…/gr-howto/lib/square_ff_impl.cc
to something like
.
.
static const int MIN_IN = 1; // mininum number of input streams
static const int MAX_IN = 1; // maximum number of input streams
.
.
gr_make_io_signature (MIN_IN, MAX_IN, sizeof (float)),

Do the values for <+MIN_IN+> and <+MAX_IN+> need to be set somewhere so
that the proper code gets generated?