Jruby-lint not catching gems

luislavena · October 21, 2011, 5:39pm

Hello,

I’ve been trying out the jruby-lint tool and it works great for stuff
like Kernel.fork and Thread.critical. But its not picking up my
non-JDBC gems.

For example, if run “rails new myapp” on MRI and there is “gem
‘sqlite3’” in my Gemfile. jrlint says everything is OK.

I see sqlite3 on the wiki page:

And I’ve looked at the checker:

github.com

jruby/jruby-lint/blob/master/lib/jruby/lint/checkers/gem.rb

module JRuby::Lint::Checkers
  module CheckGemNode
    def self.add_wiki_link_finding(collector)
      unless @added_wiki_link
        collector.add_finding("For more on gem compatibility see https://github.com/jruby/jruby/wiki/C-Extension-Alternatives", [:gems, :info]).tap do |f|
          def f.to_s
            message
          end
        end
        @added_wiki_link = true
      end
    end

    def gem_name(node)
      first_arg = node&.args_node&.child_nodes[0]
      first_arg.value.to_s if first_arg&.node_type&.to_s == "STRNODE"
    end

    def jruby_gem_entry?(node)
      node&.args_node&.child_nodes.each do |child|

This file has been truncated. show original

But I can’t figure out what’s going on. Where does the checker get the
wiki address from? I see it in the message, but no where else.

Thanks,

-Joe

morganhilljoe · October 21, 2011, 5:55pm

See

github.com

jruby/jruby-lint/blob/master/lib/jruby/lint/libraries.rb#L75


      
                  in_suggestions = false
                  break
                else
                  _, key, value = line.gsub(/[\[\]]/, '').split("|", 3)
                  @gems[key.downcase] = value
                end
              end
            rescue => e
              @error = "Unable to load C Extension alternatives list: #{e.message}"
            end
          end
          
          
SOURCES = [CExtensions]
          
          
attr_accessor :gems
          
          
def initialize(cache)
            @sources = SOURCES.map {|s| s.new(cache) }
          end
          
          
def load

and line the read_from_wiki method on line 37 of the same file.

Just glancing, it looks like the css selector may no longer be right.

Ben

morganhilljoe · October 21, 2011, 8:51pm

Nope, turns out it because i was using --1.9. Works fine with 1.8

Here’s the underlying error.It gets trapped and discarded. So it never
bubbles up

#<NoMethodError: undefined method read_nonblock' for #<OpenSSL::SSL::SSLSocket:0x7099e017>> ~/.rvm/rubies/jruby-1.6.4/lib/ruby/1.9/net/protocol.rb:135:inrbuf_fill’
~/.rvm/rubies/jruby-1.6.4/lib/ruby/1.9/net/protocol.rb:116:in readuntil' ~/.rvm/rubies/jruby-1.6.4/lib/ruby/1.9/net/protocol.rb:126:inreadline’
~/.rvm/rubies/jruby-1.6.4/lib/ruby/1.9/net/http.rb:2211:in read_status_line' ~/.rvm/rubies/jruby-1.6.4/lib/ruby/1.9/net/http.rb:2200:inread_new’
~/.rvm/rubies/jruby-1.6.4/lib/ruby/1.9/net/http.rb:1183:in transport_request' ~/.rvm/rubies/jruby-1.6.4/lib/ruby/1.9/net/http.rb:1169:inrequest’
~/.rvm/rubies/jruby-1.6.4/lib/ruby/1.9/net/http.rb:880:in get' ~/.rvm/gems/jruby-1.6.4/gems/jruby-lint-0.3.0/lib/jruby/lint/libraries.rb:51:inread_from_wiki’

morganhilljoe · October 21, 2011, 8:54pm

Oh, yep. I’ve seen that error too in 1.9 mode. There’s a discussion
about the problem here:

http://jira.codehaus.org/browse/JRUBY-5529

/Nick

morganhilljoe · October 21, 2011, 7:24pm

Thanks Ben! I think you are right. I’ll see if I can fix it and submit
a pull request.