Rails 3.0.3 breaks arjdbc?

Dobai-Pataky_BSSSSl · November 24, 2010, 8:57pm

Hey Folks,

I am seeing an odd problem here. I upgraded to Rails 3.0.3 and all of
the sudden the arjdbc gem isn’t selecting the correct adapter code
anymore… I’m using DB2 and it’s using the generic jdbc adapter instead
of the db2 adapter. A symptom of which is “LIMIT” being used (generic
jdbc) instead of “FETCH FIRST ROW ONLY” (db2/adapter.rb).

I’ve verified this with a new Rails 3.0.3 app… generic jdbc is used.
Switched Rails to 3.0.0 in Gemfile, bundle install’ed and volla
adapter/db2.rb is correctly being used again.

Has anyone else seen this problem?

Thanks!
- nick

Nicholas_J_Kreucher · November 24, 2010, 9:45pm

Hi Nick,

See

The next release should fix this. If I can get a couple of Oracle bugs
fixed, maybe that will be later today.

/Nick

Nicholas_J_Kreucher · November 25, 2010, 1:20am

Hi Nick,

Ah… ARel 2 problems then? Fun!

So with this commit (using up through de66a6e now actually), running
rake test_db2 I still get alot of errors

    40 tests, 26 assertions, 0 failures, 22 errors

Here is a sample (hint: it’s still using LIMIT w/3.0.3, killing most
tests):

gist.github.com

https://gist.github.com/kreucher/714677

gistfile1.txt

  1) Error:
test_boolean(DB2SimpleTest):
ActiveRecord::StatementInvalid: ActiveRecord::JDBCError: DB2 SQL Error: SQLCODE=-104, SQLSTATE=42601, SQLERRMC=1;FROM db_types LIMIT;END-OF-STATEMENT, DRIVER=3.57.82: SELECT db_types.* FROM db_types LIMIT 1
    /home/kreucher/.gem/jruby/1.8/gems/activerecord-3.0.3/lib/active_record/connection_adapters/abstract_adapter.rb:202:in `log'
    /home/kreucher/src/activerecord-jdbc-adapter-master/lib/arjdbc/jdbc/adapter.rb:183:in `execute'
    /home/kreucher/src/activerecord-jdbc-adapter-master/lib/arjdbc/jdbc/adapter.rb:272:in `select'
    /home/kreucher/.gem/jruby/1.8/gems/activerecord-3.0.3/lib/active_record/connection_adapters/abstract/database_statements.rb:7:in `select_all'
    /home/kreucher/.gem/jruby/1.8/gems/activerecord-3.0.3/lib/active_record/connection_adapters/abstract/query_cache.rb:56:in `select_all'
    /home/kreucher/.gem/jruby/1.8/gems/activerecord-3.0.3/lib/active_record/base.rb:467:in `find_by_sql'
    /home/kreucher/.gem/jruby/1.8/gems/activerecord-3.0.3/lib/active_record/relation.rb:64:in `to_a'

This file has been truncated. show original

I’ll poke around a bit, but ARel 2 and this visitor concept is quite new
to me.

Thanks!
- nick

Nicholas_J_Kreucher · November 26, 2010, 5:42pm

It would be great if you can help get DB2 green again on 3.0.3. I
tried to port the logic from the add_limit_offset! function, but
apparently wasn’t quite succesful.

/Nick