Re: [Patch] Support for G_TYPE_VALUE_ARRAY

Desktop Ruby-Gnome 2
1

Hi Sjoerd,

On Tue, 9 May 2006 23:53:08 +0200
[email protected] (Sjoerd S.) wrote:

Hi,

Attached patch adds convertions functions to and from G_TYPE_VALUE_ARRAY
GValue’s… These are used by some gstreamer plugins.

You comment the source as “ValueArray is treated as Array”.
And your convertion functions seems to convert GValueArray ↔
Array(Ruby)

Then, the code below needless?
G_DEF_CLASS(G_TYPE_VALUE_ARRAY, “ValueArray”, mGLib);

If we don’t use GLib::ValueArray from Ruby side, we shouldn’t define it.

–
.:% Masao M.[email protected]

2

On Sun, May 14, 2006 at 07:42:59PM +0900, Masao M. wrote:

You comment the source as “ValueArray is treated as Array”.
And your convertion functions seems to convert GValueArray ↔ Array(Ruby)

Then, the code below needless?
G_DEF_CLASS(G_TYPE_VALUE_ARRAY, “ValueArray”, mGLib);

If we don’t use GLib::ValueArray from Ruby side, we shouldn’t define it.

Correct that code is useless. It’s basically copied it from the
rbgobj_strv.c :slight_smile:

Sjoerd

Each man is his own prisoner, in solitary confinement for life.

Using Tomcat but need to do more? Need to support web services,
security?
Get stuff done quickly with pre-integrated technology to make your job
easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

3

Hi,

On Wed, 17 May 2006 15:40:37 +0200
[email protected] (Sjoerd S.) wrote:

You comment the source as “ValueArray is treated as Array”.
And your convertion functions seems to convert GValueArray ↔ Array(Ruby)

Then, the code below needless?
G_DEF_CLASS(G_TYPE_VALUE_ARRAY, “ValueArray”, mGLib);

If we don’t use GLib::ValueArray from Ruby side, we shouldn’t define it.

Correct that code is useless. It’s basically copied it from the rbgobj_strv.c :slight_smile:

Ah, it’s my mistake.

I removed both and applied your patch to CVS.

Thanks.

–
.:% Masao M.[email protected]

Using Tomcat but need to do more? Need to support web services,
security?
Get stuff done quickly with pre-integrated technology to make your job
easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642