Hi,
I upgraded my radiant installation from admin_parts to shards yesterday,
and
it works like a charm.
Today, I wanted to give admin_tree_structure a try because I’m begining
to
get a bit too much posts on my blog 0:-)
It kinda works, but the “comments” column added by the comments
extension on
the pages listing is empty now (what a surprise, as both override
_node.rhtml) but I can live without it.
Now, there’s something strange with the tree expansion, if I expand and
collapse something, I can’t reexpand it, and from time to time, I can’t
even
collapse something I’ve expanded.
Any idea ?
Today, I wanted to give admin_tree_structure a try because I’m begining to
get a bit too much posts on my blog 0:-)
It kinda works, but the “comments” column added by the comments extension on
the pages listing is empty now (what a surprise, as both override
_node.rhtml) but I can live without it.
Now, there’s something strange with the tree expansion, if I expand and
collapse something, I can’t reexpand it, and from time to time, I can’t even
collapse something I’ve expanded.
Any idea ?
I’m guessing it’s because of the javascript changes in shards and
core. I haven’t made changes to admin_tree_structure since then, so
it’s probably broken. I’ll have a look-see.
We really need to get some browser-based testing (selenium maybe?), as
javascript bugs seem to be a fair proportion of the problems these
days.
Dan.
I upgraded my radiant installation from admin_parts to shards
yesterday, and
it works like a charm.
Today, I wanted to give admin_tree_structure a try because
Have just updated admin_tree_structure to work with the latest core +
shards.
http://soxbox.no-ip.org/radiant/svn/extensions/admin_tree_structure
Make sure to load Shards first. In your environment.rb:
Define extension load order
config.extensions = [ :shards, :all ]
±Le 15/11/07 17:08 +1100, Daniel S. a dit :
|> I upgraded my radiant installation from admin_parts to shards
|> yesterday, and
|> it works like a charm.
|> Today, I wanted to give admin_tree_structure a try because
|
| Have just updated admin_tree_structure to work with the latest core +
| shards.
|
| http://soxbox.no-ip.org/radiant/svn/extensions/admin_tree_structure
I hate to say that it does not change much. I do have the comments
column
that’s back, but only on the pages that are on the first level, plus,
the
little + does not change into a - when expanded :
http://mat.cc/distfiles/admin_tree_strangeness.pdf
(Does the same in FireFox and in Safari, both with cleared cache.)
Try refreshing your browser once the three is expanded. This works
for me at least.
I do not know why the comments column does not show up when pushing
(+), but think Daniel, John or Sean said it had something to do with
the sitemap javascript.
Greetings
Hans-Christian Fjeldberg
[email protected]
Ignore my last post!!!
I have the same problems as you describe it seems. Without the
admin_tree_structure extension, only the comments extension.
Greetings
Hans-Christian Fjeldberg
[email protected]
±le 15.11.2007 07:11:21 -0600, Ryan H. a dit :
| Make sure to load Shards first. In your environment.rb:
|
| # Define extension load order
| config.extensions = [ :shards, :all ]
That’s already the case.
Sorry…
Even onMouseClickRow is called two times when pushing the plus (+) sign.
Greetings
Hans-Christian Fjeldberg
[email protected]
I haven’t figured out the answer to the problem, but more
specifically the problem seems to be that toggleExpanded in
SiteMap.js is called two times (using FireBug).
I haven’t figured out why or from where it is called two times.
Greetings
Hans-Christian Fjeldberg
[email protected]
Daniel S. wrote:
We really need to get some browser-based testing (selenium maybe?), as
javascript bugs seem to be a fair proportion of the problems these
days.
I second.
I’ve been looking at the selenium_on_rails plugin to add testing for an
extension that I’m working on. I’d love to see not only radiant using
selenium but to have it integrate with extensions (after all, they’re
the source of much of the breakage).
Writing good tests might get sticky in certain cases where extension A
overrides extension B or Radiant, though.
-Chris
I’ve been looking at the selenium_on_rails plugin to add
testing for an
extension that I’m working on. I’d love to see not only
radiant using
selenium but to have it integrate with extensions (after all, they’re
the source of much of the breakage).
Writing good tests might get sticky in certain cases where
extension A
overrides extension B or Radiant, though.
Hence this:
http://soxbox.no-ip.org/radiant/svn/extensions/test_filtering/
Which allows your extensions to declare which tests they’re breaking on
purpose.
I live for a clean rake test && rake test:extensions
Dan.
| http://soxbox.no-ip.org/radiant/svn/extensions/admin_tree_structure
I hate to say that it does not change much. I do have the
comments column
that’s back, but only on the pages that are on the first
level, plus, the
little + does not change into a - when expanded :
http://mat.cc/distfiles/admin_tree_strangeness.pdf
(Does the same in FireFox and in Safari, both with cleared cache.)
Since Hans mentioned that he’s getting this problem with only the
comments extension installed, I’m guessing the source of the
problem is there.
Do the tests on admin_tree_structure still pass? (rake test:extensions
EXT=admin_tree_structure)
Dan.
±Le 16/11/07 09:01 +1100, Daniel S. a dit :
|
|> ±Le 15/11/07 17:08 +1100, Daniel S. a dit :
|> |> I upgraded my radiant installation from admin_parts to shards
|> |> yesterday, and
|> |> it works like a charm.
|> |> Today, I wanted to give admin_tree_structure a try because
|> |
|> | Have just updated admin_tree_structure to work with the
|> latest core +
|> | shards.
|> |
|> | http://soxbox.no-ip.org/radiant/svn/extensions/admin_tree_structure
|>
|> I hate to say that it does not change much. I do have the
|> comments column
|> that’s back, but only on the pages that are on the first
|> level, plus, the
|> little + does not change into a - when expanded :
|> http://mat.cc/distfiles/admin_tree_strangeness.pdf
|> (Does the same in FireFox and in Safari, both with cleared cache.)
|
| Since Hans mentioned that he’s getting this problem with only the
| comments extension installed, I’m guessing the source of the problem is
| there.
|
| Do the tests on admin_tree_structure still pass? (rake test:extensions
| EXT=admin_tree_structure)
$ rake test:extensions EXT=admin_tree_structure
(in /usr/home/mat/web)
(in /usr/home/mat/web/vendor/extensions/admin_tree_structure)
/usr/local/bin/ruby18 -Ilib:lib
“/usr/local/lib/ruby/gems/1.8/gems/rake-0.7.3/lib/rake/rake_test_loader.rb”
“test/functional/admin_tree_structure_extension_test.rb”
/usr/home/mat/web/config/…/config/environment.rb:4: warning: already
initialized constant RADIANT_GEM_VERSION
Loaded suite
/usr/local/lib/ruby/gems/1.8/gems/rake-0.7.3/lib/rake/rake_test_loader
Started
…
Finished in 25.284529 seconds.
5 tests, 158 assertions, 0 failures, 0 errors
I think it does.
±Le 15/11/07 16:47 +0100, Hans-Christian Fjeldberg a dit :
| Sorry…
|
| Even onMouseClickRow is called two times when pushing the plus (+) sign.
Looks like shards:r604 fixed all the rendering problem I had.